Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl:support 'show create table with compression' #7782

Merged
merged 2 commits into from
Sep 26, 2018
Merged

ddl:support 'show create table with compression' #7782

merged 2 commits into from
Sep 26, 2018

Conversation

ciscoxll
Copy link
Contributor

@ciscoxll ciscoxll commented Sep 26, 2018 •
edited
Loading

What problem does this PR solve?

We should support syntax 'create table/alter table with compression'.

  • Master branch already supports syntax 'create table/alter table with compression'.
  • So currently PR only support 'show create table with compression'.

What is changed and how it works?

  • Added Compression field in TableInfo.
  • TableInfo.Compression saves the set compression type.
  • Displayed if the compression typed is set.

Check List

Tests

  • Unit test

@ciscoxll ciscoxll changed the title ddl:support syntax 'show create table with compression' ddl:support 'show create table with compression' Sep 26, 2018
@ciscoxll
Copy link
Contributor Author

@jackysp @winkyao @crazycs520 PTAL.

crazycs520
crazycs520 reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciscoxll ciscoxll added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2018
winkyao
winkyao reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciscoxll ciscoxll added status/LGT3 The PR has already had 3 LGTM. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/LGT3 The PR has already had 3 LGTM. labels Sep 26, 2018
@ciscoxll
Copy link
Contributor Author

/run-all-tests

zz-jason
zz-jason approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 26, 2018
@ciscoxll ciscoxll merged commit cfd4544 into pingcap:master Sep 26, 2018
@ciscoxll ciscoxll deleted the compression-syntax branch September 26, 2018 10:13
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@crazycs520 crazycs520 crazycs520 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciscoxll @zz-jason @winkyao @crazycs520 @you06 @sre-bot