Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add config force-priority #7777

Merged
merged 2 commits into from
Sep 25, 2018
Merged

config: add config force-priority #7777

merged 2 commits into from
Sep 25, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Sep 25, 2018 •
edited
Loading

What problem does this PR solve?

Fix #7524, add config force-priority. The force-priority should be set in the TiDB config file. There is no need to set the priority when the TiDB server is rebooted.

What is changed and how it works?

Add the config force-priority in the config file and make it effect.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Manually changed the config file to check the statement priority of it.

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to update the tidb-ansible repository

PTAL @shenli @coocood

@jackysp jackysp added the type/enhancement The issue or PR belongs to an enhancement. label Sep 25, 2018
winoros
winoros reviewed Sep 25, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zimulala
zimulala approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 25, 2018
zhexuany
zhexuany reviewed Sep 25, 2018
View reviewed changes
Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit f387dff into pingcap:master Sep 25, 2018
@morgo morgo mentioned this pull request Sep 26, 2018
Closed
@jackysp jackysp deleted the priority_config branch October 8, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zhexuany zhexuany zhexuany left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @zimulala @winoros @zhexuany