Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix enum type flag bug #7438

Merged
merged 1 commit into from
Aug 20, 2018
Merged

server: fix enum type flag bug #7438

merged 1 commit into from
Aug 20, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Aug 20, 2018

What problem does this PR solve?

fix bug introduced by #7417 and failure of CI

What is changed and how it works?

fix use EnumFlag instead of TypeEnum

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • mistake fix

Side effects

  • no

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Aug 20, 2018

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Aug 20, 2018

@coocood @tiancaiamao PTAL

@lysu lysu added the type/bugfix This PR fixes a bug. label Aug 20, 2018
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2018
@lysu
Copy link
Contributor Author

lysu commented Aug 20, 2018

/run-integration-common-test

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2018
@coocood coocood merged commit 97b60c9 into master Aug 20, 2018
@coocood coocood deleted the lysu-patch-1 branch August 20, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants