Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add 'IDENTIFIED WITH' option on create user statement #7402

Merged
merged 3 commits into from
Aug 17, 2018
Merged

parser: add 'IDENTIFIED WITH' option on create user statement #7402

merged 3 commits into from
Aug 17, 2018

Conversation

imtbkcat
Copy link

What problem does this PR solve?

Fix #7295 to make JDBC test happy.

What is changed and how it works?

An CNF grammar rule is added to support IDENTIFIED WITH in CREATE USER.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects
no

Related changes

@jackysp
Copy link
Member

jackysp commented Aug 15, 2018

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 15, 2018
@imtbkcat imtbkcat requested a review from coocood August 16, 2018 07:43
@imtbkcat
Copy link
Author

PTAL @jackysp @tiancaiamao

@imtbkcat
Copy link
Author

/run-all-tests

@coocood
Copy link
Member

coocood commented Aug 17, 2018

LGTM

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2018
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@coocood
Copy link
Member

coocood commented Aug 17, 2018

/run-mybatis-test

@tiancaiamao tiancaiamao merged commit 2ae4f7f into pingcap:master Aug 17, 2018
@imtbkcat imtbkcat deleted the fix7295 branch August 17, 2018 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants