-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: drop partition information in 'show create table' #7388
Conversation
executor/show.go
Outdated
} | ||
} | ||
buf.WriteString(")") | ||
// Partition info is truncated in release-2.0 branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the comment in line 592 and remove the following lines.
PTAL @shenli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0 |
@shenli Ping |
What problem does this PR solve?
Fix
show create table
in release 2.0Before this change, create a table like this:
show create table
results in:It's a illegal SQL and would make syncer broken.
What is changed and how it works?
#6630 fix it in the master branch, but it's hard to cherry-pick.
There is a related fix in
show create table
like #6332And also this one #7379
And also some parser related changes for the cherry-pick.
In one word, it's fixed so many times, but never got right.
In this PR, I just drop the partition information, no code, not bug.
Check List
Tests
Side effects
show create table
in release 2.0 branch will not display table partition any more.@shenli @zhexuany @winkyao