Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/charset: Add utf8mb4 as alias for utf8 #7339

Merged
merged 5 commits into from
Aug 10, 2018
Merged

util/charset: Add utf8mb4 as alias for utf8 #7339

merged 5 commits into from
Aug 10, 2018

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Aug 9, 2018

Supports applications which directly change to utf8mb4 charset.
Safe for TiDB to treat both as the same.
Fixes #7267

What have you changed? (mandatory)

Added an alias for utf8mb4 as a character set. It is treated the same as utf8.

What is the type of the changes? (mandatory)

Bug fix/compatibility improvement.

How has this PR been tested? (mandatory)

Manual testing:

mysql> SELECT CONVERT( CONVERT( 'xxx' USING ascii ) USING utf8mb4 ) AS xxx;
+------+
| xxx  |
+------+
| xxx  |
+------+
1 row in set (0.00 sec)

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

Release note: Compatibility fix: utf8mb4 has been added as an alias for utf8.

Refer to a related PR or issue link (optional)

Fixes #7267

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@sre-bot
Copy link
Contributor

sre-bot commented Aug 9, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@shenli
Copy link
Member

shenli commented Aug 9, 2018

@morgo Please add a test case for this PR.

@shenli
Copy link
Member

shenli commented Aug 9, 2018

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Aug 9, 2018

/run-unit-test

Supports applications which directly change to utf8mb4 charset.
Safe for TiDB to treat both as the same.
Fixes #7267
@shenli
Copy link
Member

shenli commented Aug 10, 2018

/run-all-tests

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 10, 2018
@coocood coocood merged commit 3efb8d7 into pingcap:master Aug 10, 2018
@morgo morgo deleted the utf8mb4-alias branch August 14, 2018 16:44
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support utf8mb4 as alias for utf8
6 participants