Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix panic caused by outdated feedback (#7128) #7155

Merged
merged 2 commits into from
Jul 25, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jul 25, 2018

What have you changed? (mandatory)

Cherry pick #7128

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Unit test.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Does this PR need to be added to the release notes? (mandatory)

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 25, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2018
@shenli
Copy link
Member

shenli commented Jul 25, 2018

LGTM

@shenli shenli added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2018
@shenli shenli merged commit a78037d into pingcap:release-2.0 Jul 25, 2018
@alivxxx alivxxx deleted the feedback-panic branch July 26, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants