plan: fix a bug in index join #7150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci failed @winoros |
|
/run-all-tests |
XuHuaiyu
reviewed
Jul 26, 2018
expression/explain.go
Outdated
| @@ -60,12 +61,26 @@ func (expr *Constant) format(dt types.Datum) string { | |||
| } | |||
|
|
|||
| // ExplainExpressionList generates explain information for a list of expressions. | |||
| func ExplainExpressionList(exprs []Expression) []byte { | |||
| func ExplainExpressionList(exprs []Expression, needSort bool) []byte { | |||
There was a problem hiding this comment.
add a comment for needSort
|
@XuHuaiyu PTAL |
zz-jason
requested changes
Jul 26, 2018
expression/explain.go
Outdated
| @@ -60,12 +61,28 @@ func (expr *Constant) format(dt types.Datum) string { | |||
| } | |||
|
|
|||
| // ExplainExpressionList generates explain information for a list of expressions. | |||
| func ExplainExpressionList(exprs []Expression) []byte { | |||
| // needSort will be true if the exprs should keep its order. In some scenarios, the expr's order may not be valid | |||
There was a problem hiding this comment.
why the order of the exprs may not be valid?
There was a problem hiding this comment.
There's map access when extract same part from DNF. So the order after this cannot be valid.
There was a problem hiding this comment.
Uh, I think stable is a better word. By the way, this function only used when we explain a sql, and the performance doesn't matter, I think we can force to sort the exprs to simplify the function signature, and this function can be renamed to SortAndExplainExpressionList.
zz-jason
approved these changes
Jul 30, 2018
XuHuaiyu
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
wrongly usage of golang's
copyWhat is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
newly added explain test.