Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid unnecessary function call #7120

Merged
merged 2 commits into from
Jul 23, 2018
Merged

avoid unnecessary function call #7120

merged 2 commits into from
Jul 23, 2018

Conversation

ngaut
Copy link
Member

@ngaut ngaut commented Jul 22, 2018

No description provided.

shenli
shenli reviewed Jul 22, 2018
View reviewed changes
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any benchmark for this? There are a lot of usage in this patten. If it does work, we will change all of them.

@ngaut
Copy link
Member Author

ngaut commented Jul 22, 2018

It's just one more function call. The benchmark should very close to #7071

@coocood
Copy link
Member

coocood commented Jul 23, 2018

LGTM

zz-jason
zz-jason approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@ngaut ngaut merged commit fc0ad93 into pingcap:master Jul 23, 2018
@ngaut ngaut deleted the ngaut/less-function-call branch July 23, 2018 02:08
@lysu lysu mentioned this pull request Jul 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenli shenli shenli left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngaut @coocood @zz-jason @shenli