variable, ddl: add session variable 'tidb_ddl_reorg_priority' to set operation priority of ddl reorg #7116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operation priority of ddl reorg
|
Please add proper labels. |
|
This PR should be metioned in the release notes. |
|
/run-all-tests |
winkyao
added
component/DDL-need-LGT3
release-note
…rol_reorg_priority
|
@winkyao Please resolve conflicts. |
…rol_reorg_priority
crazycs520
reviewed
Aug 5, 2018
|
|
||
| cli.mu.Lock() | ||
| cli.mu.checkFlags = checkRequestOff | ||
| cli.mu.Unlock() |
There was a problem hiding this comment.
I can't understand the test is used to test what?
There was a problem hiding this comment.
test if the following set priority operation takes effect.
There was a problem hiding this comment.
Which line to check if the following set priority operation takes effect?
There was a problem hiding this comment.
You can look into checkRequestClient.SendRequest
…rol_reorg_priority
crazycs520
reviewed
Aug 7, 2018
|
|
||
| cli.mu.Lock() | ||
| cli.mu.checkFlags = checkRequestOff | ||
| cli.mu.Unlock() |
meta/meta.go
Outdated
| job := &model.Job{} | ||
| job := &model.Job{ | ||
| // for compability, if the job is enqueued by old version TiDB and Priority field is omitted, | ||
| // set the default priority to kv.PriorityLow |
meta/meta.go
Outdated
| @@ -504,8 +504,16 @@ func (m *Meta) getDDLJob(key []byte, index int64) (*model.Job, error) { | |||
| return nil, errors.Trace(err) | |||
| } | |||
|
|
|||
| job := &model.Job{} | |||
| job := &model.Job{ | |||
| // for compability, if the job is enqueued by old version TiDB and Priority field is omitted, | |||
meta/meta.go
Outdated
| err = job.Decode(value) | ||
| // check job.Priority is valid. |
zhexuany
reviewed
Aug 8, 2018
| case "priority_normal": | ||
| s.DDLReorgPriority = kv.PriorityNormal | ||
| case "priority_high": | ||
| s.DDLReorgPriority = kv.PriorityHigh |
There was a problem hiding this comment.
maybe add a default clause?
|
LGTM |
ciscoxll
approved these changes
Aug 8, 2018
crazycs520
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Add session variable 'tidb_ddl_reorg_priority' to set operation priority of ddl reorg. Before this PR, the operation in adding indices is definitely in low priority, In some case, we want to finish DDL job as fast as possible, after this PR, we can set the variable
tidb_ddl_reorg_prioritytopriority_highto achieve it.What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
UT
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
YES
Does this PR affect tidb-ansible update? (mandatory)
NO
Does this PR need to be added to the release notes? (mandatory)
YES:
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)