*: remove non-prepared plan cache #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-prepared plan cache is not useable if we can only do full string match. And further development doesn't worth the effort.
|
@zz-jason @tiancaiamao PTAL |
|
/run-all-tests |
zz-jason
reviewed
Jul 12, 2018
session/session.go
Outdated
| if recordSets, err = s.executeStatement(ctx, connID, stmtNode, stmt, recordSets); err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| // Step4: Execute the physical plan. |
| @@ -1,58 +0,0 @@ | |||
| // Copyright 2017 PingCAP, Inc. | |||
There was a problem hiding this comment.
this could be useful, maybe we can save it.
There was a problem hiding this comment.
We can always find the code from git history when we need it.
|
@zz-jason PTAL |
|
LGTM |
|
@tiancaiamao PTAL |
|
LGTM |
|
/run-all-tests |
|
And update the document too. |
1 similar comment
|
And update the document too. |
coocood
added
the
release-note
|
/run-all-tests |
ngaut
approved these changes
Jul 13, 2018
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Remove non-prepared plan cache。
What is the type of the changes? (mandatory)
non-prepared plan cache is not useable if we can only do full string match.
And further development doesn't worth the effort.
How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Yes
Does this PR affect tidb-ansible update? (mandatory)
Yes
Does this PR need to be added to the release notes? (mandatory)
release note:
Remove
plan-cacheconfig option.