plan: always chose the smaller child as outer for IndexJoin #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
added
type/enhancement
winoros
requested changes
Jul 19, 2018
plan/exhaust_physical_plans.go
Outdated
| return join, true | ||
| } | ||
| plans = append(plans, join...) | ||
| lhsCardinality := p.Children()[0].cardinality() |
There was a problem hiding this comment.
Merge master and you can use p.Childrend()[0].StatsInfo().Count() now.
plan/exhaust_physical_plans.go
Outdated
| } | ||
| plans = append(plans, join...) | ||
| lhsCardinality := p.Children()[0].cardinality() | ||
| rhsCardinality := p.Children()[1].cardinality() |
plan/plan.go
Outdated
| @@ -184,6 +184,8 @@ type LogicalPlan interface { | |||
| // deriveStats derives statistic info between plans. | |||
| deriveStats() (*statsInfo, error) | |||
|
|
|||
| cardinality() float64 | |||
|
@winoros PTAL |
|
@XuHuaiyu PTAL |
|
/run-all-tests |
zz-jason
added
status/LGT2
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Aug 1, 2018
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Aug 1, 2018
zz-jason
added a commit
that referenced
this pull request
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
cherry pick #6996 to master
What are the type of the changes (mandatory)?
How has this PR been tested (mandatory)?