plan: refine explain result format #7011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
zz-jason
added
type/enhancement
zhexuany
reviewed
Jul 9, 2018
plan/explain.go
Outdated
| @@ -116,7 +116,7 @@ func (p *PhysicalIndexReader) ExplainInfo() string { | |||
|
|
|||
| // ExplainInfo implements PhysicalPlan interface. | |||
| func (p *PhysicalIndexLookUpReader) ExplainInfo() string { | |||
| return fmt.Sprintf("index:%s, table:%s", p.indexPlan.ExplainID(), p.tablePlan.ExplainID()) | |||
| return "" | |||
There was a problem hiding this comment.
Maybe better to add comment to explain why only return "" to its caller?
|
Well Done. Except the comment of function, other Part looks good to me. If you resolve this, just ping me so that I can approve this PR. ;) |
|
/run-all-tests |
|
/run-common-test |
|
/run-integration-common-test |
winoros
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Delete redundant IndexLookUp description and move the
costcolumn next toidto make it more noticeable.What are the type of the changes (mandatory)?
How has this PR been tested (mandatory)?
unit test