*: kill one's own connection doesn't require SUPER privilege #6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kill tidb connID`, if the user is the owner of that connection, there is no need to check the SUPER privilege. SessionManager interface is slightly modified.
shenli
reviewed
Jul 2, 2018
| // If you have the SUPER privilege, you can kill all threads and statements. | ||
| // Otherwise, you can kill only your own threads and statements. | ||
| sm := b.ctx.GetSessionManager() | ||
| if sm != nil { |
There was a problem hiding this comment.
In the test code
util/processinfo.go
Outdated
| @@ -33,6 +33,6 @@ type ProcessInfo struct { | |||
| // SessionManager is an interface for session manage. Show processlist and | |||
| // kill statement rely on this interface. | |||
| type SessionManager interface { | |||
| ShowProcessList() []ProcessInfo | |||
| ShowProcessList() map[uint64]ProcessInfo | |||
There was a problem hiding this comment.
Add comment for the return value.
| // Otherwise, you can kill only your own threads and statements. | ||
| sm := b.ctx.GetSessionManager() | ||
| if sm != nil { | ||
| processList := sm.ShowProcessList() |
There was a problem hiding this comment.
Could you add an interface for SessionManger like GetProcessByConnID(connID) ?
There was a problem hiding this comment.
GetProcessByConnID make SessionManager more complex.
GetProcessByConnID can be implemented using ShowProcessList which is already in SessionManager
I assume Kill will not be too frequency so this choice would not hurt the performance.
@shenli
There was a problem hiding this comment.
So the interface ShowProcessList returns a map instead of a list.
|
@tiancaiamao Please fix the CI. |
|
/run-all-tests |
zimulala
approved these changes
Jul 4, 2018
|
/run-all-tests |
|
/run-all-tests |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Jul 6, 2018
…#6954) `kill tidb connID`, if the user is the owner of that connection, there is no need to check the SUPER privilege. SessionManager interface is slightly modified.
zz-jason
pushed a commit
that referenced
this pull request
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
kill tidb connID, if the user is the owner of that connection, thereis no need to check the SUPER privilege.
SessionManager interface is slightly modified.
What are the type of the changes (mandatory)?
How has this PR been tested (mandatory)?
It's somehow difficult to test this change. I check it manually.
PTAL @jackysp