Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support session variable 'warning_count' and 'error_count' #6945

Merged
merged 6 commits into from
Jul 2, 2018
Merged

*: support session variable 'warning_count' and 'error_count' #6945

merged 6 commits into from
Jul 2, 2018

Conversation

spongedu
Copy link
Contributor

What have you changed? (mandatory)

  1. Support show @@waring_count and show @@error_count in TiDB

  2. The modification that add an return value of error type for ResetStmtCtx is to make kisielk/errcheck happy.

What are the type of the changes (mandatory)?

enhancement

How has this PR been tested (mandatory)?

Unittest

@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. contribution This PR is from a community contributor. labels Jul 2, 2018
@shenli
Copy link
Member

shenli commented Jul 2, 2018

/run-all-tests

zz-jason
zz-jason reviewed Jul 2, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 2, 2018
jackysp
jackysp approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 2, 2018
@coocood
Copy link
Member

coocood commented Jul 2, 2018

@spongedu
Can we remove WarningCount?

@spongedu
Copy link
Contributor Author

spongedu commented Jul 2, 2018

@coocood we still need WarningCount. The behavior of the new added NumWarnings is a little different from WarningCount in behavior. For example, if the last sql statement generates a warning;
both WarningCount and NumWarnings 1, then if we execute SHOW WARNINGS after that, WarningCount would be 0, and NumWarnings is still 1.

@coocood
Copy link
Member

coocood commented Jul 2, 2018

LGTM

@coocood coocood merged commit 2292844 into pingcap:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spongedu @shenli @coocood @jackysp @zz-jason