server: fix binary numeric type overflow #6922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
commented
Jun 27, 2018
| @@ -273,9 +273,9 @@ func parseStmtArgs(args []interface{}, boundParams [][]byte, nullBitmap, paramTy | |||
| } | |||
|
|
|||
| if isUnsigned { | |||
There was a problem hiding this comment.
Actually, I think binary int does not have an unsigned flag.
jackysp
commented
Jun 27, 2018
| @@ -329,7 +329,7 @@ func parseStmtArgs(args []interface{}, boundParams [][]byte, nullBitmap, paramTy | |||
| return | |||
| } | |||
|
|
|||
| args[i] = float64(math.Float32frombits(binary.LittleEndian.Uint32(paramValues[pos : pos+4]))) | |||
| args[i] = math.Float32frombits(binary.LittleEndian.Uint32(paramValues[pos : pos+4])) | |||
There was a problem hiding this comment.
Don't know why there is a cast here, either.
|
Maybe unit tests from MySQL official jdbc are usefully to cover the binary type code. |
|
/run-all-tests |
shenli
reviewed
Jun 27, 2018
| @@ -273,9 +273,9 @@ func parseStmtArgs(args []interface{}, boundParams [][]byte, nullBitmap, paramTy | |||
| } | |||
|
|
|||
| if isUnsigned { | |||
| args[i] = uint64(paramValues[pos]) | |||
| args[i] = uint8(paramValues[pos]) | |||
|
Where is the integration test? |
|
LGTM |
lysu
reviewed
Jun 28, 2018
zimulala
reviewed
Jul 7, 2018
server/conn_stmt.go
Outdated
| @@ -288,9 +288,9 @@ func parseStmtArgs(args []interface{}, boundParams [][]byte, nullBitmap, paramTy | |||
| } | |||
| valU16 := binary.LittleEndian.Uint16(paramValues[pos : pos+2]) | |||
| if isUnsigned { | |||
| args[i] = uint64(valU16) | |||
| args[i] = uint16(valU16) | |||
server/conn_stmt.go
Outdated
| @@ -302,9 +302,9 @@ func parseStmtArgs(args []interface{}, boundParams [][]byte, nullBitmap, paramTy | |||
| } | |||
| valU32 := binary.LittleEndian.Uint32(paramValues[pos : pos+4]) | |||
| if isUnsigned { | |||
| args[i] = uint64(valU32) | |||
| args[i] = uint32(valU32) | |||
| @@ -329,7 +329,7 @@ func parseStmtArgs(args []interface{}, boundParams [][]byte, nullBitmap, paramTy | |||
| return | |||
| } | |||
|
|
|||
| args[i] = float64(math.Float32frombits(binary.LittleEndian.Uint32(paramValues[pos : pos+4]))) | |||
| args[i] = math.Float32frombits(binary.LittleEndian.Uint32(paramValues[pos : pos+4])) | |||
There was a problem hiding this comment.
Do we need to add a test case for this type?
There was a problem hiding this comment.
No need to do it.
- There's no signed or unsigned float.
- jdbc test cases in tidb-test will cover this. The unit test is not suitable for this case.
|
/run-common-test tidb-test=pr/564 |
|
PTAL @zimulala |
zimulala
added
status/LGT2
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Jul 27, 2018
coocood
pushed a commit
that referenced
this pull request
Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
When using jdbc to setInt(-1) to an int type column, it will cause an overflow error.
What are the type of the changes (mandatory)?
Bug fix.
How has this PR been tested (mandatory)?
Integration tests.
PTAL @coocood @lysu