Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix COM_FIELD_LIST response bug that make mariadb-client crash during use db #6918

Merged
merged 6 commits into from
Jun 28, 2018
Merged

server: fix COM_FIELD_LIST response bug that make mariadb-client crash during use db #6918

merged 6 commits into from
Jun 28, 2018

Commits on Jun 28, 2018

  1. server: fix COM_FIELD_LIST response. 

    [column-definitions](https://dev.mysql.com/doc/internals/en/com-query-response.html#column-definition) in COM_FIELD_LIST response need write addition default-values part even though we omit default-values.
and some client like MariaDB-cli will read default-values length bit and meet fault if we haven't give it.
https://github.com/MariaDB/server/blob/72b6d01848e56a75349d663bc61bbe71f97a280b/sql-common/client.c#L1519

fix #6622
    @lysu
    lysu committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    37e06d8 View commit details
    Browse the repository at this point in the history

  2. server: fix review comment.

    @lysu
    lysu committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    5fe93ae View commit details
    Browse the repository at this point in the history

  3. server: fix review comment.

    @lysu
    lysu committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    0b6ce2f View commit details
    Browse the repository at this point in the history

  4. server: fix review comment. 

    we should open for continue edition that fill default value.
    @lysu
    lysu committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    0547af6 View commit details
    Browse the repository at this point in the history

  5. server: fix review comment.

    @lysu
    lysu committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    91bccdf View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into dev-fix-maria-db-client

    @zz-jason
    zz-jason authored Jun 28, 2018
    Configuration menu
    Copy the full SHA
    e2626d7 View commit details
    Browse the repository at this point in the history