expression: use maximum length for integer display

[dveeden]

What problem does this PR solve?

Issue Number: close #56462 close #45338 close #41719

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Issues related to casting integers with a non-default display width to strings have been fixed.

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dveeden]

/ok-to-test

[dveeden]

/check-issue-triage-complete

[dveeden]

This looks good:

mysql-8.0.11-TiDB-v8.4.0-alpha-325-g74034d4ac2-dirty> DROP TABLE IF EXISTS test.t;
Query OK, 0 rows affected (0.02 sec)

mysql-8.0.11-TiDB-v8.4.0-alpha-325-g74034d4ac2-dirty> CREATE TABLE test.t (id bigint(11) UNSIGNED PRIMARY KEY);
Query OK, 0 rows affected (0.01 sec)

mysql-8.0.11-TiDB-v8.4.0-alpha-325-g74034d4ac2-dirty> INSERT INTO test.t VALUES (1234567890123456);
Query OK, 1 row affected (0.00 sec)

mysql-8.0.11-TiDB-v8.4.0-alpha-325-g74034d4ac2-dirty> SELECT IFNULL(id, 'abcdef') FROM test.t;
+----------------------+
| IFNULL(id, 'abcdef') |
+----------------------+
| 1234567890123456     |
+----------------------+
1 row in set (0.00 sec)

This should result in a warning and truncation, but no longer does:

mysql-8.0.11-TiDB-v8.4.0-alpha-325-g74034d4ac2-dirty> WITH a AS (SELECT 1234 v) SELECT CAST(v AS CHAR(2)) FROM a;
+--------------------+
| CAST(v AS CHAR(2)) |
+--------------------+
| 1234               |
+--------------------+
1 row in set (0.00 sec)

[Defined2014]

Hi @dveeden, is this PR ready for review? And I think this PR also could fix #45338

Maybe we should modified setFlenFromArgs function to fix it.

[dveeden]

Hi @dveeden, is this PR ready for review?

Not yet, the problem. There is a regression that needs to be fixed. See #56463 (comment) for details.

And I think this PR also could fix #45338

Yes, correct.

Maybe we should modified setFlenFromArgs function to fix it.

[dveeden]

Maybe we should modified setFlenFromArgs function to fix it.

Yes. Thanks!

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.9180%. Comparing base (0f6bddd) to head (b6acaa3).
Report is 24 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56463         +/-   ##
=================================================
- Coverage   73.3958%   56.9180%   -16.4779%     
=================================================
  Files          1628       1753        +125     
  Lines        449554     634330     +184776     
=================================================
+ Hits         329954     361048      +31094     
- Misses        99344     249394     +150050     
- Partials      20256      23888       +3632     

Flag	Coverage Δ
integration	37.3189% <77.7777%> (?)
unit	73.2594% <66.6666%> (+0.7411%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	52.5008% <ø> (+6.9060%)	⬆️

[dveeden]

/retest

[dveeden]

/retest

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-11 13:20:24.773985278 +0000 UTC m=+18021.922895111: ☑️ agreed by Defined2014.
• 2024-10-12 08:58:20.354477799 +0000 UTC m=+88697.503387630: ☑️ agreed by lance6716.

[lance6716]

/assign @windtalker

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,XuHuaiyu,lance6716]
• pkg/expression/OWNERS [XuHuaiyu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dveeden]

/retest

[dveeden]

/retest

[dveeden]

/retest