planner: remove the unused collectPredicateColumns flag

[winoros]

What problem does this PR solve?

Issue Number: ref #53567

Problem Summary:

What changed and how does it work?

Clean up for some future improvements.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

[codecov]

Codecov Report

Attention: Patch coverage is 96.84211% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.6214%. Comparing base (b520f61) to head (ddfd7d1).
Report is 91 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56386         +/-   ##
=================================================
- Coverage   73.3867%   58.6214%   -14.7654%     
=================================================
  Files          1620       1774        +154     
  Lines        447041     657130     +210089     
=================================================
+ Hits         328069     385219      +57150     
- Misses        98877     247773     +148896     
- Partials      20095      24138       +4043     

Flag	Coverage Δ
integration	40.4826% <96.8421%> (?)
unit	74.8297% <96.8421%> (+2.3514%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	53.7152% <100.0000%> (+8.1859%)	⬆️

[Rustin170506]

Looks good to me. Thanks! 👍

[Rustin170506]

/retest

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-10 11:27:32.572493591 +0000 UTC m=+1131807.992706598: ☑️ agreed by Rustin170506.
• 2024-10-10 13:42:33.610743606 +0000 UTC m=+1139909.030956619: ☑️ agreed by hawkingrei.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/planner/OWNERS [Rustin170506,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[winoros]

/retest

[winoros]

/retest

[winoros]

/retest