Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix sub_part in information_schema.statistics table|tidb-test=pr/2400 #56208

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55814

What problem does this PR solve?

Issue Number: close #55812

Problem Summary: We didn't set sub_part column correctly in information_schema.statistics table, just fix it.
Also found a bug related with mysql-tester. pingcap/mysql-tester#131

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Sep 23, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2024
@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 23, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@cdd7546). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #56208   +/-   ##
================================================
  Coverage               ?   72.0138%           
================================================
  Files                  ?       1413           
  Lines                  ?     411965           
  Branches               ?          0           
================================================
  Hits                   ?     296672           
  Misses                 ?      95398           
  Partials               ?      19895           
Flag Coverage Δ
unit 72.0138% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5326% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 02:18:34.063596531 +0000 UTC m=+1445983.804020454: ☑️ agreed by lcwangchao.
  • 2024-09-23 08:02:03.121611978 +0000 UTC m=+1466592.862035916: ☑️ agreed by Defined2014.

@Defined2014 Defined2014 force-pushed the cherry-pick-55814-to-release-7.5 branch from b88e5f9 to 789aa3e Compare September 23, 2024 08:22
@Defined2014
Copy link
Contributor

/retest

1 similar comment
@Defined2014
Copy link
Contributor

/retest

@Defined2014
Copy link
Contributor

/retest

@Defined2014 Defined2014 changed the title infoschema: fix sub_part in information_schema.statistics table (#55814) infoschema: fix sub_part in information_schema.statistics table|tidb-test=pr/2400 (#55814) Sep 23, 2024
@Defined2014 Defined2014 changed the title infoschema: fix sub_part in information_schema.statistics table|tidb-test=pr/2400 (#55814) infoschema: fix sub_part in information_schema.statistics table|tidb-test=pr/2400 Sep 23, 2024
@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4b69818 into pingcap:release-7.5 Sep 23, 2024
18 checks passed
@Defined2014 Defined2014 deleted the cherry-pick-55814-to-release-7.5 branch September 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants