executor: fix data race in IndexNestedLoopHashJoin (#55824)

[ti-chi-bot]

This is an automated cherry-pick of #55824

What problem does this PR solve?

Issue Number: close #49692

Problem Summary:

• IndexNestedLoopHashJoin.panicErr is not thread-safe

What changed and how does it work?

• make IndexNestedLoopHashJoin.panicErr can not be read until it has been initialized.
• add failpoint TestIssue49692 to make sure the context done branch can be executed.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Manual test:

• Remove

  tidb/pkg/executor/join/index_lookup_hash_join.go

  Lines 204 to 209 in 4a1a771

  	if !e.KeepOuterOrder {
  	e.resultCh <- &indexHashJoinResult{err: err}
  	} else {
  	task := &indexHashJoinTask{err: err}
  	e.taskCh <- task
  	}

  and make sure

  tidb/pkg/executor/join/index_lookup_hash_join.go

  Lines 302 to 306 in 4a1a771

  	failpoint.Inject("TestIssue49692", func() {
  	for !e.panicErr.Load() {
  	runtime.Gosched()
  	}
  	})

  can be triggered.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@8fa6619). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.5     #55908   +/-   ##
================================================
  Coverage               ?   71.9969%           
================================================
  Files                  ?       1413           
  Lines                  ?     411866           
  Branches               ?          0           
================================================
  Hits                   ?     296531           
  Misses                 ?      95434           
  Partials               ?      19901           

Flag	Coverage Δ
unit	71.9969% <82.6087%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9400% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	53.5230% <0.0000%> (?)

[ti-chi-bot]

@solotzg: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test unit-test

The following commands are available to trigger optional jobs:

• /test pull-br-integration-test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-ddl-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-integration-nodejs-test
• /test pull-integration-python-orm-test
• /test pull-mysql-client-test
• /test pull-sqllogic-test
• /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/release-7.5/ghpr_build
• pingcap/tidb/release-7.5/ghpr_check
• pingcap/tidb/release-7.5/ghpr_check2
• pingcap/tidb/release-7.5/ghpr_mysql_test
• pingcap/tidb/release-7.5/ghpr_unit_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@solotzg: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[solotzg]

/test check-dev2

[tiprow]

@solotzg: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XuHuaiyu,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-10 02:25:13.675427219 +0000 UTC m=+323183.415851154: ☑️ agreed by XuHuaiyu.
• 2024-09-10 07:42:23.512380004 +0000 UTC m=+342213.252803938: ☑️ agreed by wshwsh12.