Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema, meta: fix wrong auto id after rename table #55847

Merged
merged 6 commits into from
Sep 6, 2024
Merged

infoschema, meta: fix wrong auto id after rename table #55847

merged 6 commits into from
Sep 6, 2024

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Sep 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #55846 #53329

Problem Summary:

What changed and how does it work?

In the previous logic, rename table will reuse the old Allocator.

For the first case in the issue, drop database will clear all related meta data with old schema. So the next call of rebase4Signed will allocate ids from 0.

For the second case, after infoschema reload, the Allocator created in loadTableInfo will allocate id starting from 0, which may generate duplicated keys.

This affects both v1 and v2.

To solve these problem, old meta will be copied for new table after rename table. So new table will never get an already allocated id.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 4, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joechenrh
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 4, 2024
@joechenrh
Copy link
Contributor Author

/retest

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.9183%. Comparing base (638c05f) to head (70644d6).
Report is 23 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #55847         +/-   ##
=================================================
- Coverage   72.8565%   56.9183%   -15.9382%     
=================================================
  Files          1595       1752        +157     
  Lines        443510     636652     +193142     
=================================================
+ Hits         323126     362372      +39246     
- Misses       100503     249484     +148981     
- Partials      19881      24796       +4915
Flag Coverage Δ
integration 39.6063% <30.0000%> (?)
unit 72.0800% <73.3333%> (+0.1227%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.1208% <ø> (+16.6912%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
@joechenrh
Copy link
Contributor Author

/retest

1 similar comment
@joechenrh
Copy link
Contributor Author

/retest

@joechenrh joechenrh changed the title *: fix wrong auto id after rename table infoschema, meta: fix wrong auto id after rename table Sep 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 12:58:50.779819245 +0000 UTC m=+449255.297872171: ☑️ agreed by wjhuang2016.
  • 2024-09-05 06:21:40.557361293 +0000 UTC m=+511825.075414219: ☑️ agreed by tiancaiamao.

@joechenrh
Copy link
Contributor Author

/retest

@joechenrh
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2024
@joechenrh
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2024
@joechenrh
Copy link
Contributor Author

/retest

1 similar comment
@joechenrh
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 59040d0 into pingcap:master Sep 6, 2024
25 checks passed
breezewish added a commit to breezewish/tidb that referenced this pull request Sep 8, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/truncate-vecs
87c4984 
* origin/master: (33 commits)
  build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 (pingcap#55762)
  build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 (pingcap#55894)
  planner: fix incorrect estRows with global index and json column (pingcap#55842)
  ddl, stat: switch to new struct for add/truncate/drop partition (pingcap#55893)
  planner: hide instance plan cache eviction log if no plan is evicted (pingcap#55918)
  expression: support tidb encode key function (pingcap#51678)
  planner: fix incorrect maintenance of `handleColHelper` for recursive CTE (pingcap#55732)
  executor: some code refine of hash join v2 (pingcap#55887)
  infoschema, meta: fix wrong auto id after `rename table` (pingcap#55847)
  ddl/ingest: set `minCommitTS` when detect remote duplicate keys (pingcap#55588)
  planner: move index advisor into the kernel (pingcap#55874)
  ddl, stats: switch to new struct for create/truncate table (pingcap#55811)
  executor: avoid new small objects in probe stage of hash join v2 (pingcap#55855)
  *: Add tidbCPU/tikvCPU into system tables (pingcap#55455)
  ddl: use static contexts in `NewReorgCopContext` (pingcap#55823)
  executor: fix index out of range bug in hash join v2 (pingcap#55864)
  executor: record index usage for the clustered primary keys (pingcap#55602)
  domain: load all non-public tables into infoschema (pingcap#55142)
  test: fix unstable TestShowViewPriv (pingcap#55868)
  ttl: add `varbinary` case for `TestSplitTTLScanRangesWithBytes` (pingcap#55863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joechenrh @tiancaiamao @wjhuang2016