-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fetch schemas in work pool in case of reporting a error in one goroutine. #55841
Conversation
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55841 +/- ##
=================================================
- Coverage 72.8428% 56.9829% -15.8600%
=================================================
Files 1598 1754 +156
Lines 444498 635245 +190747
=================================================
+ Hits 323785 361981 +38196
- Misses 100768 248318 +147550
- Partials 19945 24946 +5001
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.cn>
bd69ead
to
dd219bd
Compare
Signed-off-by: joccau <zak.zhao@pingcap.com.cn>
8fa342d
to
7d148d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
503e61f
to
2912251
Compare
Signed-off-by: joccau <zak.zhao@pingcap.cn>
2912251
to
ba97c0b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Ref #54436
Problem Summary:
errgroup
replace it.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.