Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: move index advisor into the kernel #55820

Merged
merged 29 commits into from
Sep 4, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 3, 2024

What problem does this PR solve?

Issue Number: ref #12303

Problem Summary: planner: move index advisor into the kernel

What changed and how does it work?

planner: move index advisor into the kernel

  1. Add models and a set structure required by the Index Advisor;
  2. Add a new interface Optimizer to encapsulate all APIs required by the Index Advisor;
  3. Add more UTs

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 3, 2024
Copy link

tiprow bot commented Sep 3, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 70.12195% with 196 lines in your changes missing coverage. Please review.

Project coverage is 56.3154%. Comparing base (eb19c10) to head (b387a3c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55820         +/-   ##
=================================================
- Coverage   72.8613%   56.3154%   -16.5460%     
=================================================
  Files          1595       1724        +129     
  Lines        449065     616886     +167821     
=================================================
+ Hits         327195     347402      +20207     
- Misses       101574     245943     +144369     
- Partials      20296      23541       +3245     
Flag Coverage Δ
integration 37.4818% <0.1524%> (?)
unit 72.0001% <70.1219%> (+0.0624%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (+0.0266%) ⬆️
parser ∅ <ø> (∅)
br 52.6692% <ø> (+7.2936%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 3, 2024

/test unit-test

Copy link

tiprow bot commented Sep 3, 2024

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

}

// Set is the interface for a set.
type Set[T SetKey] interface {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, move this code into util/set to allow more people to use it.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 4, 2024

Thanks for your comments, all comments have been addressed! @hawkingrei

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
Copy link

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 06:57:17.624656777 +0000 UTC m=+427562.142709887: ☑️ agreed by hawkingrei.
  • 2024-09-04 08:01:54.407802484 +0000 UTC m=+431438.925855409: ☑️ agreed by elsa0520.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 4, 2024

/test unit-test

Copy link

tiprow bot commented Sep 4, 2024

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit e00454a into pingcap:master Sep 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants