Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: remove old useless unfinished index advisor implementation #55810

Merged
merged 2 commits into from
Sep 4, 2024
Merged

planner: remove old useless unfinished index advisor implementation #55810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa0120
fixup
qw4990 Sep 3, 2024
c9359e2
fixup
qw4990 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/executor/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ go_library(
"foreign_key.go",
"grant.go",
"import_into.go",
"index_advise.go",
"index_merge_reader.go",
"infoschema_reader.go",
"insert.go",
Expand Down Expand Up @@ -330,7 +329,6 @@ go_test(
"historical_stats_test.go",
"hot_regions_history_table_test.go",
"import_into_test.go",
"index_advise_test.go",
"infoschema_cluster_table_test.go",
"infoschema_reader_internal_test.go",
"infoschema_reader_test.go",
Expand Down
17 changes: 0 additions & 17 deletions pkg/executor/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ func (b *executorBuilder) build(p base.Plan) exec.Executor {
return b.buildLockStats(v)
case *plannercore.UnlockStats:
return b.buildUnlockStats(v)
case *plannercore.IndexAdvise:
return b.buildIndexAdvise(v)
case *plannercore.PlanReplayer:
return b.buildPlanReplayer(v)
case *plannercore.PhysicalLimit:
Expand Down Expand Up @@ -1089,21 +1087,6 @@ func (b *executorBuilder) buildUnlockStats(v *plannercore.UnlockStats) exec.Exec
return e
}

func (b *executorBuilder) buildIndexAdvise(v *plannercore.IndexAdvise) exec.Executor {
e := &IndexAdviseExec{
BaseExecutor: exec.NewBaseExecutor(b.ctx, nil, v.ID()),
IsLocal: v.IsLocal,
indexAdviseInfo: &IndexAdviseInfo{
Path: v.Path,
MaxMinutes: v.MaxMinutes,
MaxIndexNum: v.MaxIndexNum,
LineFieldsInfo: v.LineFieldsInfo,
Ctx: b.ctx,
},
}
return e
}

func (b *executorBuilder) buildPlanReplayer(v *plannercore.PlanReplayer) exec.Executor {
if v.Load {
e := &PlanReplayerLoadExec{
Expand Down
146 changes: 0 additions & 146 deletions pkg/executor/index_advise.go
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions pkg/executor/index_advise_test.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pkg/parser/ast/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
go_library(
name = "ast",
srcs = [
"advisor.go",
"ast.go",
"base.go",
"ddl.go",
Expand Down
85 changes: 0 additions & 85 deletions pkg/parser/ast/advisor.go
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions pkg/parser/ast/ast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,6 @@ func GetStmtLabel(stmtNode StmtNode) string {
return "Use"
case *CreateBindingStmt:
return "CreateBinding"
case *IndexAdviseStmt:
return "IndexAdvise"
case *DropBindingStmt:
return "DropBinding"
case *TraceStmt:
Expand Down
Loading