expression: avoid refinement of arguments on nullable value

[tuziemon]

What problem does this PR solve?

Issue Number: close #44706

Problem Summary:

What changed and how does it work?

Currently, the equation of an unsigned int constant and a signed int column is replaced by the equation of constants 1 and 0.
However, this produces an incorrect result if the column is null, so a check for notnullflag should be added.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Hi @tuziemon. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @tuziemon. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9203%. Comparing base (c721542) to head (43be0d8).
Report is 42 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55805         +/-   ##
=================================================
- Coverage   74.9500%   55.9203%   -19.0297%     
=================================================
  Files          1585       1730        +145     
  Lines        367989     638574     +270585     
=================================================
+ Hits         275808     357093      +81285     
- Misses        72382     257193     +184811     
- Partials      19799      24288       +4489     

Flag	Coverage Δ
integration	23.1461% <0.0000%> (?)
unit	71.9699% <100.0000%> (-2.0478%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (-2.2327%)	⬇️
parser	∅ <ø> (∅)
br	51.8046% <ø> (+4.4907%)	⬆️

[tuziemon]

/retest

[tuziemon]

/retest

[lance6716]

Thanks. Can you add an test that shows the SQL in #44706 now returns correct result? You can take a look at pkg/expression/integration_test/integration_test.go

[tuziemon]

Thank you for your comment.
I added the integration test to pkg/expression/integration_test/integration_test.go.

[lance6716]

/cc @zanmato1984 @windtalker

[tuziemon]

/retest

[windtalker]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/expression/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-06 01:43:52.211055215 +0000 UTC m=+581556.729108141: ☑️ agreed by windtalker.