-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: watch the ddl ownerkey with the createRevision #55692
Conversation
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55692 +/- ##
=================================================
- Coverage 72.9210% 56.3741% -16.5469%
=================================================
Files 1585 1713 +128
Lines 443451 620011 +176560
=================================================
+ Hits 323369 349526 +26157
- Misses 100237 246895 +146658
- Partials 19845 23590 +3745
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: joccau <zak.zhao@pingcap.com.cn>
7354c7a
to
fa415b1
Compare
fa415b1
to
831f8b6
Compare
Signed-off-by: joccau <zak.zhao@pingcap.cn>
3f54cb8
to
2297be5
Compare
Signed-off-by: joccau <zak.zhao@pingcap.cn>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-dev |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ref #54436 |
What problem does this PR solve?
A tidb-server run campaignOwner successfully and become owner. If it watches the owner after the ownerKey is deleted, the watchOwner() will be stuck.
The method to fix it: need to watch the owner since createRevision.
Issue Number: close #54689, ref #54436
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.