Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix duplicated table check would block incremental restore #55688

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Aug 27, 2024

What problem does this PR solve?

Issue Number: close #55562

Problem Summary:

BR would report unexpected BR:Restore:ErrTablesAlreadyExisted when incremental restore.

What changed and how does it work?

disable duplicated table check in incremental restore.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2024
Copy link

tiprow bot commented Aug 27, 2024

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.2883%. Comparing base (290dc46) to head (8b8162f).
Report is 40 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55688         +/-   ##
=================================================
- Coverage   72.9295%   57.2883%   -15.6413%     
=================================================
  Files          1581       1714        +133     
  Lines        442365     626323     +183958     
=================================================
+ Hits         322615     358810      +36195     
- Misses        99938     243196     +143258     
- Partials      19812      24317       +4505     
Flag Coverage Δ
integration 38.6079% <100.0000%> (?)
unit 72.0198% <0.0000%> (+0.0197%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.8016% <100.0000%> (+17.3468%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2024
@RidRisR
Copy link
Contributor Author

RidRisR commented Sep 2, 2024

/test check-dev2

@RidRisR
Copy link
Contributor Author

RidRisR commented Sep 2, 2024

/test pull-br-integration-test

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2024
@RidRisR
Copy link
Contributor Author

RidRisR commented Sep 3, 2024

/test unit-test

Copy link

tiprow bot commented Sep 3, 2024

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2024
Copy link

ti-chi-bot bot commented Sep 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-03 07:45:30.056069289 +0000 UTC m=+344054.574122209: ☑️ agreed by Leavrth.
  • 2024-09-03 11:29:28.342373363 +0000 UTC m=+357492.860426273: ☑️ agreed by BornChanger.

Copy link

tiprow bot commented Sep 3, 2024

@RidRisR: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 8b8162f link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 649dce7 into pingcap:master Sep 3, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Br SQL client will report "BR:Restore:ErrTablesAlreadyExisted" in increasement backup
3 participants