-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix duplicated table check would block incremental restore #55688
Conversation
Hi @RidRisR. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55688 +/- ##
=================================================
- Coverage 72.9295% 57.2883% -15.6413%
=================================================
Files 1581 1714 +133
Lines 442365 626323 +183958
=================================================
+ Hits 322615 358810 +36195
- Misses 99938 243196 +143258
- Partials 19812 24317 +4505
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev2 |
/test pull-br-integration-test |
/test unit-test |
@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
@RidRisR: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #55562
Problem Summary:
BR would report unexpected
BR:Restore:ErrTablesAlreadyExisted
when incremental restore.What changed and how does it work?
disable duplicated table check in incremental restore.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.