Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: statistics: add the analysis worker #55621

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Aug 23, 2024

What problem does this PR solve?

Issue Number: close #55618

Problem Summary:

This is a POC PR for #55618.

In this PR we introduced started tracking the current running tables within the refresher.
We also started always running N analysis jobs in TiDB instead of blocking the whole process in the HandleAutoAnalyze.

What changed and how does it work?

  • An analysis worker was added for the statistics refresher.
  • The analysis jobs are always spawned whenever possible.

Check List

Tests

  • Unit test(TBD)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hi-rustin <29879298+hi-rustin@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 23, 2024
@Rustin170506 Rustin170506 changed the title statistics: add the analysis worker WIP: statistics: add the analysis worker Aug 23, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
Signed-off-by: hi-rustin <29879298+hi-rustin@users.noreply.github.com>
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 78.41727% with 30 lines in your changes missing coverage. Please review.

Project coverage is 74.5355%. Comparing base (1bf01f4) to head (db3afd2).
Report is 86 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55621        +/-   ##
================================================
- Coverage   74.8168%   74.5355%   -0.2813%     
================================================
  Files          1581       1615        +34     
  Lines        367361     452007     +84646     
================================================
+ Hits         274848     336906     +62058     
- Misses        72653      94169     +21516     
- Partials      19860      20932      +1072     
Flag Coverage Δ
integration 50.4808% <28.0575%> (?)
unit 71.8637% <78.4172%> (-1.9236%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 49.7525% <ø> (+1.9847%) ⬆️

Signed-off-by: hi-rustin <29879298+hi-rustin@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+hi-rustin@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+hi-rustin@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 24, 2024
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2024
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: hi-rustin <29879298+Rustin170506@users.noreply.github.com>
Copy link

ti-chi-bot bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qw4990 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 4, 2024

@Rustin170506: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test db3afd2 link true /test mysql-test
pull-lightning-integration-test db3afd2 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2024
Copy link

ti-chi-bot bot commented Sep 6, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Auto-Analyze Mechanism for Better Concurrency
2 participants