Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: respect tidb_analyze_column_options when build analyze plan #54240

Merged
merged 18 commits into from
Jun 28, 2024
Merged

planner: respect tidb_analyze_column_options when build analyze plan #54240

merged 18 commits into from
Jun 28, 2024

Commits on Jun 27, 2024

  1. planner: respect tidb_analyze_default_column_choice when build anal… 

    …yze job

Signed-off-by: hi-rustin <rustin.liu@gmail.com>

fix

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0a1c213 View commit details
    Browse the repository at this point in the history

  2. test: add case for analyzing with predicate 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9e1c200 View commit details
    Browse the repository at this point in the history

  3. test: add TestAnalyzeTableWithTiDBPersistAnalyzeOptionsEnabled 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b29e96d View commit details
    Browse the repository at this point in the history

  4. test: add TestAnalyzeTableWithTiDBPersistAnalyzeOptionsDisabled 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b3fd184 View commit details
    Browse the repository at this point in the history

  5. test: add TestAnalyzeTableWhenV1StatsExists 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    bdd9398 View commit details
    Browse the repository at this point in the history

  6. chore: prepare bazel 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5718b08 View commit details
    Browse the repository at this point in the history

  7. test: add TestAutoAnalyzeWithPredicateColumns 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    84c048a View commit details
    Browse the repository at this point in the history

  8. test: add TestAnalyzeWhenNoPredicateColumns 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    14d47ea View commit details
    Browse the repository at this point in the history

  9. fix: do not analyze all columns 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f60ff65 View commit details
    Browse the repository at this point in the history

  10. chore: add TODO 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    407687a View commit details
    Browse the repository at this point in the history

  11. test: fix broken test 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    323172a View commit details
    Browse the repository at this point in the history

  12. chore: remove useless code 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    be79b93 View commit details
    Browse the repository at this point in the history

  13. test: fix typo 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d31c2d4 View commit details
    Browse the repository at this point in the history

  14. test: add TestAnalyzeNoPredicateColumnsWithPrimaryKey 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6ae1a3e View commit details
    Browse the repository at this point in the history

  15. fix: make bazel happy 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    04ccb5f View commit details
    Browse the repository at this point in the history

  16. test: fix broken test 

    Signed-off-by: hi-rustin <rustin.liu@gmail.com>
    @Rustin170506
    Rustin170506 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a1950b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Update pkg/planner/core/planbuilder.go 

    Co-authored-by: Arenatlx <ailinsilence4@gmail.com>
    @Rustin170506 @AilinKid
    Rustin170506 and AilinKid authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    fcee8d6 View commit details
    Browse the repository at this point in the history

  2. Update pkg/statistics/handle/usage/predicate_column_test.go

    @Rustin170506
    Rustin170506 authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5a30f87 View commit details
    Browse the repository at this point in the history