Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: update pd client #53639

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented May 29, 2024

What problem does this PR solve?

Issue Number: ref #49318 close tikv/pd#8217

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels May 29, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 29, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels May 29, 2024
@nolouch nolouch requested review from glorv and rleungx May 29, 2024 02:50
@nolouch
Copy link
Member Author

nolouch commented May 29, 2024

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label May 29, 2024
@nolouch
Copy link
Member Author

nolouch commented May 29, 2024

/retest-required

Copy link

ti-chi-bot bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
Copy link

ti-chi-bot bot commented May 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-29 03:13:48.373182542 +0000 UTC m=+2832582.130318115: ☑️ agreed by glorv.
  • 2024-05-29 03:37:09.283549404 +0000 UTC m=+2833983.040684973: ☑️ agreed by rleungx.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@eab1f8e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53639   +/-   ##
================================================
  Coverage               ?   72.0211%           
================================================
  Files                  ?       1411           
  Lines                  ?     410674           
  Branches               ?          0           
================================================
  Hits                   ?     295772           
  Misses                 ?      95013           
  Partials               ?      19889           
Flag Coverage Δ
unit 72.0211% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4700% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5c6ee34 into pingcap:release-7.5 May 29, 2024
18 checks passed
@nolouch nolouch deleted the update-pd-client branch May 29, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants