-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: column pruning should use a shallow copy slice #53237
planner: column pruning should use a shallow copy slice #53237
Conversation
The test in the issue is too long. I'm trying to simplify it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53237 +/- ##
================================================
+ Coverage 72.4582% 75.3534% +2.8952%
================================================
Files 1493 1498 +5
Lines 429362 437144 +7782
================================================
+ Hits 311108 329403 +18295
+ Misses 98985 87817 -11168
- Partials 19269 19924 +655
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/hold waiting for test cases |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold first, try to provide a test later |
/unhold |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52768
Problem Summary:
What changed and how does it work?
The slice passed to the column pruning should be shallow copied.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.