-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoid_service: fix potential autoid decrease when leader change or close for AUTO_ID_CACHE=1 (#52602) #52675
autoid_service: fix potential autoid decrease when leader change or close for AUTO_ID_CACHE=1 (#52602) #52675
Conversation
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #52675 +/- ##
================================================
Coverage ? 73.4315%
================================================
Files ? 1211
Lines ? 379965
Branches ? 0
================================================
Hits ? 279014
Misses ? 83123
Partials ? 17828 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiancaiamao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52602
What problem does this PR solve?
Issue Number: close #52600
Problem Summary:
What changed and how does it work?
Check List
Tests
See the steps in #52600
I'll file another PR to support http API, because it import new changes rather than simple bug fix.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.