planner: seperate methods in PlanContext and EvalContext/BuildContext

[lcwangchao]

What problem does this PR solve?

Issue Number: close #51381

Problem Summary:

Currently, PlanContext is an interface that extends expression.BuildContext. That is not very good because the methods in expression.BuildContext or expression.EvalContext will also be seen in PlanContext directly.

What changed and how does it work?

After this PR:

• PlanContext does not extend BuildContext anymore
• PlanContext will have a new method GetExprCtx to return the BuildContext

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #51382 (bcd04eb) into master (e586960) will increase coverage by 2.2412%.
Report is 4 commits behind head on master.
The diff coverage is 92.8240%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51382        +/-   ##
================================================
+ Coverage   70.6462%   72.8875%   +2.2412%     
================================================
  Files          1461       1461                
  Lines        434902     436958      +2056     
================================================
+ Hits         307242     318488     +11246     
+ Misses       108374      98541      -9833     
- Partials      19286      19929       +643     

Flag	Coverage Δ
integration	49.3665% <81.0185%> (?)
unit	70.3692% <84.4907%> (-0.0694%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.3772% <100.0000%> (+5.5217%)	⬆️

[D3Hunter]

lightning part lgtm

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[YangKeao]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-28 09:03:50.405762069 +0000 UTC m=+1039119.153385172: ☑️ agreed by YangKeao.
• 2024-02-28 09:07:54.362997486 +0000 UTC m=+1039363.110620597: ☑️ agreed by winoros.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, winoros, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,YangKeao,winoros]
• br/pkg/lightning/OWNERS [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment