Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix dropping non-ScalarFunction when extractCol for memtable (#40935) #51186

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #40935

Signed-off-by: Zhenchi zhongzc_arch@outlook.com

Issue Number: close #40937

Problem Summary:

We can see extractLikePatternCol and extractTimeRange will keep non-ScalarFunctions by appending them to remained.

for _, expr := range predicates {
fn, ok := expr.(*expression.ScalarFunction)
if !ok {
remained = append(remained, expr)
continue
}

for _, expr := range predicates {
fn, ok := expr.(*expression.ScalarFunction)
if !ok {
remained = append(remained, expr)
continue
}

But not for extractCol. It seems a bug.

for _, expr := range predicates {
fn, ok := expr.(*expression.ScalarFunction)
if !ok {
continue
}

What is changed and how it works?

Keep them the same.

Before this patch:

mysql root@127.0.0.1:information_schema> explain select * from `CLUSTER_HARDWARE` where `TYPE`;
+----------------+----------+------+------------------------+---------------+
| id             | estRows  | task | access object          | operator info |
+----------------+----------+------+------------------------+---------------+
| MemTableScan_5 | 10000.00 | root | table:CLUSTER_HARDWARE |               |
+----------------+----------+------+------------------------+---------------+

With this patch:

mysql root@127.0.0.1:information_schema> explain select * from `CLUSTER_HARDWARE` where `TYPE`;
+------------------+----------+------+------------------------+---------------+
| id               | estRows  | task | access object          | operator info |
+------------------+----------+------+------------------------+---------------+
| Selection_5      | 8000.00  | root |                        | Column#1      |
| └─MemTableScan_6 | 10000.00 | root | table:CLUSTER_HARDWARE |               |
+------------------+----------+------+------------------------+---------------+

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 07:34:42.370872678 +0000 UTC m=+342571.118495783: ☑️ agreed by hawkingrei.
  • 2024-02-20 07:37:22.76302882 +0000 UTC m=+342731.510651932: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 1f0ca5f into pingcap:release-6.1 Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants