Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: skip fresh check when user has specified --filter in restore full (#51010) #51041

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51010

What problem does this PR solve?

Issue Number: close #51009

Problem Summary:
In previous when user doing a full restore. we add a check to make sure the cluster must be empty. but sometime user want to do a full restore with --filter. at that time we should not check the empty cluster anymore.

What changed and how does it work?

This PR skip the check when user has set the --filter argument manually.

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    before this PR
    image
    after this PR
    image

  • No need to test

    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that makes --filter argument skip empty cluster check during full restore

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 7, 2024
@3pointer 3pointer force-pushed the cherry-pick-51010-to-release-7.5 branch from 83d0516 to 1bd7ee8 Compare February 8, 2024 10:06
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@9df78f1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #51041   +/-   ##
================================================
  Coverage               ?   71.9729%           
================================================
  Files                  ?       1403           
  Lines                  ?     407056           
  Branches               ?          0           
================================================
  Hits                   ?     292970           
  Misses                 ?      94370           
  Partials               ?      19716           
Flag Coverage Δ
unit 71.9729% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2475% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 9, 2024
Copy link

ti-chi-bot bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 9, 2024
Copy link

ti-chi-bot bot commented Feb 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-09 02:48:00.551246941 +0000 UTC m=+497806.118016831: ☑️ agreed by 3pointer.
  • 2024-02-09 02:56:21.101323285 +0000 UTC m=+498306.668093174: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit cac286c into pingcap:release-7.5 Feb 9, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants