expression: fix the incorrect result of json_length(cast(1 as json), null)
#50933
Conversation
ti-chi-bot
bot
added
do-not-merge/invalid-title
do-not-merge/needs-triage-completed
do-not-merge/needs-tests-checked
release-note-none
|
Hi @SeaRise. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
SeaRise
changed the title
json_length(cast(1 as json), null)json_length(cast(1 as json), null)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50933 +/- ##
================================================
+ Coverage 70.5281% 72.6529% +2.1248%
================================================
Files 1466 1466
Lines 434112 434511 +399
================================================
+ Hits 306171 315685 +9514
+ Misses 108699 98929 -9770
- Partials 19242 19897 +655
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
size/XXL
ti-chi-bot
bot
added
size/M
|
/check-issue-triage-complete |
|
/cc @windtalker |
pkg/expression/builtin_json_vec.go
Outdated
| @@ -860,6 +851,11 @@ func (b *builtinJSONLengthSig) vecEvalInt(ctx EvalContext, input *chunk.Chunk, r | |||
| return types.ErrInvalidJSONPathMultipleSelection | |||
| } | |||
|
|
|||
| jsonItem := jsonBuf.GetJSON(i) | |||
| if jsonItem.TypeCode != types.JSONTypeCodeObject && jsonItem.TypeCode != types.JSONTypeCodeArray { | |||
There was a problem hiding this comment.
In non-vector version, if path does not exists, it returns null, but in the vector version, if the jsonItem is not JSON object or JSON array, it returns 1 even if path does not exists? According to MySQL's behavior, the non-vector version is right.
There was a problem hiding this comment.
result.MergeNulls(pathBuf) has been call in L839, so if path is null, continue will be call in L843
There was a problem hiding this comment.
I mean the path is not null, but a non exists path. Like select json_length(cast(1 as json), '$.a')
There was a problem hiding this comment.
get! fixed and added test case.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #50931
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.