-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: support hints in 'REPLACE INTO' statement (#50007) #50677
parser: support hints in 'REPLACE INTO' statement (#50007) #50677
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
3fdf0e6
to
f0a41d7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #50677 +/- ##
================================================
Coverage ? 73.5877%
================================================
Files ? 1209
Lines ? 380059
Branches ? 0
================================================
Hits ? 279677
Misses ? 82688
Partials ? 17694 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/merge |
@tiancaiamao: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #50007
What problem does this PR solve?
Issue Number: close #34325
Problem Summary:
Hints are not supported in
REPLACE INTO ...
statement.What changed and how does it work?
I simply modify the parser to support this hints. I also tested that some simple hints (e.g.
SET_VAR
) actually work.Check List
Tests
Side effects
Documentation
Release note