ebs_br: allow temporary TiKV unreachable during starting snapshot backup (#49154) #50444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
ok-to-test
5 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XXL
Signed-off-by: hillium <yujuncen@pingcap.com>
ti-chi-bot
bot
added
size/XL
|
/retest-required |
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
YuJuncen
approved these changes
Jan 17, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #50444 +/- ##
================================================
Coverage ? 73.6541%
================================================
Files ? 1090
Lines ? 349960
Branches ? 0
================================================
Hits ? 257760
Misses ? 75648
Partials ? 16552 |
ti-chi-bot
added
the
cherry-pick-approved
BornChanger
approved these changes
Jan 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…kup (pingcap#49154) (pingcap#50444) (pingcap#37) close pingcap#49152, close pingcap#49153 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #49154
What problem does this PR solve?
Issue Number: close #49152, close #49153
Problem Summary:
See the issue.
For #49152, we didn't add retry for starting suspending lightning.
For #49153, we just break the loop when keeper encounters errors, this may cause the final consistency check passes because of the request of extend lease.
What changed and how does it work?
Fixed the problems above by retry and fail fast.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.