ebs_br: allow temporary TiKV unreachable during starting snapshot backup (#49154) #50443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
ok-to-test
5 tasks
ti-chi-bot
added
the
type/cherry-pick-for-release-7.5
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XXL
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
bot
added
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
removed
the
cherry-pick-approved
Signed-off-by: Yu Juncen <yu745514916@live.com>
…erry-pick-49154-to-release-7.5 Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
|
/retest |
ti-chi-bot
added
the
cherry-pick-approved
YuJuncen
approved these changes
Feb 20, 2024
|
/retest |
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
removed
the
needs-rebase
Signed-off-by: Yu Juncen <yu745514916@live.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #50443 +/- ##
================================================
Coverage ? 71.9665%
================================================
Files ? 1407
Lines ? 408594
Branches ? 0
================================================
Hits ? 294051
Misses ? 94763
Partials ? 19780
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
BornChanger
approved these changes
Feb 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #49154, #50316, #48439
What problem does this PR solve?
Issue Number: close #49152, close #49153
Problem Summary:
See the issue.
For #49152, we didn't add retry for starting suspending lightning.
For #49153, we just break the loop when keeper encounters errors, this may cause the final consistency check passes because of the request of extend lease.
What changed and how does it work?
Fixed the problems above by retry and fail fast.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.