Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bypass order by clause for fast point get plan (#50204) #50365

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50204

What problem does this PR solve?

Issue Number: close #49920

Problem Summary:

What changed and how does it work?

It's better to resolve order by clause, but it will make some duplicated code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 12, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 22, 2024
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 26, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:19:33.629699871 +0000 UTC m=+863662.377322982: ☑️ agreed by fixdb.
  • 2024-02-26 08:24:00.207468418 +0000 UTC m=+863928.955091529: ☑️ agreed by hawkingrei.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest-required

Signed-off-by: Jack Yu <jackysp@gmail.com>
@jackysp
Copy link
Member

jackysp commented Feb 26, 2024

    explain_test.go:314: 
        	Error Trace:	executor/explain_test.go:314
        	            				executor/explain_test.go:390
        	Error:      	Not equal: 
        	            	expected: "4"
        	            	actual  : "0"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-4
        	            	+0
        	Test:       	TestCheckActRowsWithUnistore
        	Messages:   	error comparing select * from t_unistore_act_rows

this test is not stable.

@jackysp
Copy link
Member

jackysp commented Feb 26, 2024

/retest

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Feb 26, 2024

/retest

@qw4990
Copy link
Contributor

qw4990 commented Feb 26, 2024

/test unit-test

Copy link

tiprow bot commented Feb 26, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackysp
Copy link
Member

jackysp commented Feb 26, 2024

/retest-required

@jackysp
Copy link
Member

jackysp commented Feb 26, 2024

Something wrong with CI, it says TestPhysicalTableScanExtractCorrelatedCols failed, but it is not a test case included in release 7.1, I think.

@winoros
Copy link
Member

winoros commented Feb 27, 2024

/retest

1 similar comment
@winoros
Copy link
Member

winoros commented Feb 27, 2024

/retest

@winoros
Copy link
Member

winoros commented Feb 27, 2024

/merge

Copy link

ti-chi-bot bot commented Feb 27, 2024

@winoros: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@winoros
Copy link
Member

winoros commented Feb 27, 2024

/retest

Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@1b13108). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50365   +/-   ##
================================================
  Coverage               ?   73.4148%           
================================================
  Files                  ?       1210           
  Lines                  ?     379313           
  Branches               ?          0           
================================================
  Hits                   ?     278472           
  Misses                 ?      83046           
  Partials               ?      17795           

@ti-chi-bot ti-chi-bot bot merged commit eb789e0 into pingcap:release-7.1 Feb 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants