Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: refactor sessionctx pkg's warning and note generation #49760

Merged

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #49291

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

sessionctx: refactor sessionctx pkg's warning and note generation

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 25, 2023
Copy link

tiprow bot commented Dec 25, 2023

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: AilinKid <314806019@qq.com>
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Merging #49760 (12629a9) into master (660b1f3) will increase coverage by 0.4035%.
Report is 11 commits behind head on master.
The diff coverage is 51.3513%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49760        +/-   ##
================================================
+ Coverage   70.9584%   71.3619%   +0.4035%     
================================================
  Files          1368       1428        +60     
  Lines        397089     416589     +19500     
================================================
+ Hits         281768     297286     +15518     
- Misses        95623     100482      +4859     
+ Partials      19698      18821       -877     
Flag Coverage Δ
integration 43.8645% <51.3513%> (?)
unit 70.9569% <ø> (-0.0015%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.1999% <ø> (-5.7042%) ⬇️

@AilinKid
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 25, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 25, 2023
@easonn7
Copy link

easonn7 commented Dec 25, 2023

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Dec 25, 2023
Copy link

ti-chi-bot bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2023
Copy link

ti-chi-bot bot commented Dec 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-25 08:18:27.470414791 +0000 UTC m=+1467398.507641703: ☑️ agreed by hawkingrei.
  • 2023-12-25 09:48:09.531047971 +0000 UTC m=+1472780.568274898: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 116456d into pingcap:master Dec 25, 2023
18 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49766.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 25, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@AilinKid AilinKid removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: care to use errors.new and errors.errorf as your warnings and notes
5 participants