executor: Fix the panic in `approx_percentile` function #49644

xzhangxian1008 · 2023-12-21T03:30:50Z

What problem does this PR solve?

Issue Number: close #40463

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-12-21T03:31:06Z

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xzhangxian1008 · 2023-12-21T03:32:55Z

/cc @SeaRise @XuHuaiyu @windtalker

codecov · 2023-12-21T03:42:33Z

Codecov Report

Merging #49644 (dab705f) into master (56bf775) will increase coverage by 0.1919%.
Report is 90 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #49644        +/-   ##
================================================
+ Coverage   70.9792%   71.1712%   +0.1919%     
================================================
  Files          1368       1430        +62     
  Lines        398687     430861     +32174     
================================================
+ Hits         282985     306649     +23664     
- Misses        95933     105041      +9108     
+ Partials      19769      19171       -598

Flag	Coverage Δ
integration	`43.8977% <100.0000%> (?)`
unit	`70.9797% <ø> (+0.0004%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9663% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`45.8037% <ø> (-7.0727%)`	⬇️

pkg/executor/aggfuncs/aggfunc_test.go

pkg/executor/aggfuncs/builder.go

xzhangxian1008 · 2023-12-22T01:00:45Z

/cc @SeaRise @windtalker

pkg/executor/aggfuncs/builder.go

SeaRise

Others LGTM

SeaRise · 2023-12-22T02:22:18Z

pkg/executor/aggfuncs/func_percentile_test.go

@@ -57,3 +59,12 @@ func TestPercentile(t *testing.T) {
 		require.Equal(t, want, data[index])
 	}
 }
+
+func TestFix40463(t *testing.T) {


And add the sql in #40463 to ft?
https://github.com/pingcap/tidb/tree/master/tests/integrationtest

And add the sql in #40463 to ft? https://github.com/pingcap/tidb/tree/master/tests/integrationtest

okk

ti-chi-bot · 2023-12-27T01:48:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-12-27T01:48:17Z

[LGTM Timeline notifier]

Timeline:

2023-12-22 02:22:35.058740826 +0000 UTC m=+1186846.095967754: ☑️ agreed by SeaRise.
2023-12-27 01:48:16.144480433 +0000 UTC m=+1616787.181707345: ☑️ agreed by guo-shaoge.

xzhangxian1008 · 2023-12-29T02:34:12Z

/unhold

xzhangxian1008 · 2023-12-29T05:14:29Z

/retest

tiprow · 2023-12-29T05:14:54Z

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-12-29T06:43:13Z

In response to a cherrypick label: new pull request created to branch release-6.5: #49910.