Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global sort: bench new merge step #49595

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Dec 20, 2023

What problem does this PR solve?

Issue Number: ref #48952

Problem Summary:

bench merge step with different implementation and concurrency.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
    requests:
    cpu: 15000m
    memory: 56Gi
    storage: 3500Gi
bench_test.go:969: merge speed for 1310720900 bytes in 15.208387281s with 1 concurrency, speed: 82.19 MB/s, ascending file
bench_test.go:969: merge speed for 1310720900 bytes in 9.597459202s with 1 concurrency, speed: 130.24 MB/s, random file
bench_test.go:969: merge speed for 1310720900 bytes in 8.137010907s with 2 concurrency, speed: 153.62 MB/s, ascending file
bench_test.go:969: merge speed for 1310720900 bytes in 6.131138584s with 2 concurrency, speed: 203.88 MB/s, random file
bench_test.go:969: merge speed for 1310720900 bytes in 5.028285528s with 4 concurrency, speed: 248.59 MB/s, ascending file
bench_test.go:969: merge speed for 1310720900 bytes in 4.41710165s with 4 concurrency, speed: 282.99 MB/s, random file
bench_test.go:969: merge speed for 1310720900 bytes in 5.049378811s with 8 concurrency, speed: 247.56 MB/s, ascending file
bench_test.go:969: merge speed for 1310720900 bytes in 3.869761845s with 8 concurrency, speed: 323.02 MB/s, random file
bench_test.go:1017: new merge speed for 1310720900 bytes in 6.763902622s, speed: 184.80 MB/s, ascending file
bench_test.go:1017: new merge speed for 1310720900 bytes in 5.82777614s, speed: 214.49 MB/s, random file

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2023
Copy link

tiprow bot commented Dec 20, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #49595 (ff9962e) into master (7d33d0d) will increase coverage by 0.4612%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49595        +/-   ##
================================================
+ Coverage   71.0024%   71.4636%   +0.4612%     
================================================
  Files          1368       1421        +53     
  Lines        399178     415723     +16545     
================================================
+ Hits         283426     297091     +13665     
- Misses        95967      99833      +3866     
+ Partials      19785      18799       -986     
Flag Coverage Δ
integration 43.6693% <ø> (?)
unit 71.0024% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3644% <ø> (-5.5178%) ⬇️

@ywqzzy ywqzzy changed the title global sort: bench new merge step [WIP]global sort: bench new merge step Dec 20, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Dec 20, 2023
@ywqzzy ywqzzy changed the title [WIP]global sort: bench new merge step global sort: bench new merge step Dec 20, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2023
Copy link

ti-chi-bot bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2023
Copy link

ti-chi-bot bot commented Dec 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-20 04:11:05.658430365 +0000 UTC m=+1020556.695657293: ☑️ agreed by D3Hunter.
  • 2023-12-20 05:00:46.369607581 +0000 UTC m=+1023537.406834507: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit d84df2b into pingcap:master Dec 20, 2023
32 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants