Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: ignore TypeNULL in HandleBinaryLiteral (#49527) #49533

Merged
merged 3 commits into from
Dec 22, 2023
Merged

expression: ignore TypeNULL in HandleBinaryLiteral (#49527) #49533

merged 3 commits into from
Dec 22, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49527

What problem does this PR solve?

Issue Number: close #49526

Problem Summary:

What changed and how does it work?

Ignore the TypeNull in HandleBinaryLiteral, as the castStringToString will actually do nothing for NULL (except changing the type).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
This is an automated cherry-pick of pingcap#49527
9d82b7e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2023
Merged
13 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@b14df20). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #49533   +/-   ##
================================================
  Coverage               ?   71.9501%           
================================================
  Files                  ?       1400           
  Lines                  ?     406565           
  Branches               ?          0           
================================================
  Hits                   ?     292524           
  Misses                 ?      94334           
  Partials               ?      19707
Flag Coverage Δ
unit 71.9501% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2656% <0.0000%> (?)

resolve conflict
8f2fdd0 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member

/retest

1 similar comment
@YangKeao
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 21, 2023
@lcwangchao
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 21, 2023
YangKeao
YangKeao approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 07:05:12.627806065 +0000 UTC m=+1117403.665032978: ☑️ agreed by lcwangchao.
  • 2023-12-21 07:06:57.225026077 +0000 UTC m=+1117508.262253004: ☑️ agreed by YangKeao.

@YangKeao
Copy link
Member

/retest

7 similar comments
@YangKeao
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@lcwangchao
Copy link
Collaborator

/retest

@lcwangchao
Copy link
Collaborator

/retest

@lcwangchao
Copy link
Collaborator

/retest

@lcwangchao
Copy link
Collaborator

/retest

@YangKeao
Copy link
Member

/retest

fix go.sum
253c1f9 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member

/retest

@lcwangchao
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot removed the approved label Dec 22, 2023
windtalker
windtalker approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, windtalker, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit 5235cb6 into pingcap:release-7.5 Dec 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@windtalker windtalker windtalker approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @YangKeao @lcwangchao @hawkingrei @windtalker