expression: ignore NULL in handle binary literal (#49527) #49528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
release-note-none
ti-chi-bot
bot
added
the
size/S
ti-chi-bot
bot
added
needs-1-more-lgtm
YangKeao
added
the
needs-cherry-pick-release-7.1
tangenta
approved these changes
Dec 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ti-chi-bot
bot
added
size/M
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #49528 +/- ##
================================================
Coverage ? 73.6387%
================================================
Files ? 1087
Lines ? 349486
Branches ? 0
================================================
Hits ? 257357
Misses ? 75603
Partials ? 16526 |
13 tasks
ti-chi-bot
added
the
cherry-pick-approved
|
In response to a cherrypick label: new pull request created to branch |
13 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Dec 21, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…gcap#49528) (pingcap#34) close pingcap#49526 Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manually cherry-pick of #49527
What problem does this PR solve?
Issue Number: close #49526
Problem Summary:
What changed and how does it work?
Ignore the
TypeNullinHandleBinaryLiteral, as thecastStringToStringwill actually do nothing for NULL (except changing the type).Check List
Tests
Side effects
Documentation
Release note