Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/util/dbutil: remove dependency stmtctx from dbutil #48913

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #48911

Problem Summary:

What changed and how does it work?

Remove a simple usage of stmtctx in the dbutil.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      These codes are covered by existing tests.

Release note

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2023
@YangKeao YangKeao requested a review from xhebox November 27, 2023 04:37
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #48913 (c4ddf61) into master (2e277dc) will decrease coverage by 17.4578%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #48913         +/-   ##
=================================================
- Coverage   70.9913%   53.5335%   -17.4578%     
=================================================
  Files          1368       1585        +217     
  Lines        404965     596925     +191960     
=================================================
+ Hits         287490     319555      +32065     
- Misses        97471     254916     +157445     
- Partials      20004      22454       +2450     
Flag Coverage Δ
integration 35.1221% <ø> (?)
unit 71.0402% <100.0000%> (+0.0489%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 55.4648% <ø> (+2.3935%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2023
Copy link

ti-chi-bot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2023
Copy link

ti-chi-bot bot commented Nov 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 06:16:33.296047654 +0000 UTC m=+817021.961273849: ☑️ agreed by hawkingrei.
  • 2023-11-27 06:42:52.99664573 +0000 UTC m=+818601.661871925: ☑️ agreed by lcwangchao.

@ti-chi-bot ti-chi-bot bot merged commit 2f29c1c into pingcap:master Nov 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dependency stmtctx from pkg/util/dbutil
3 participants