-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external/test: compare the performance of merge iter #48560
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @D3Hunter |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48560 +/- ##
================================================
+ Coverage 71.4161% 72.8139% +1.3978%
================================================
Files 1403 1427 +24
Lines 406992 413830 +6838
================================================
+ Hits 290658 301326 +10668
+ Misses 96390 93554 -2836
+ Partials 19944 18950 -994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/cc @ywqzzy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
generate the speed, CPU/heap profile for reading from external storage. See below.
Check List
Tests
The data is evenly distributed in files. We can see that even in this case merge iterator is slower than concurrent reading.
and here's the CPU flame graph of merge iter. We will improve the performance in future PR.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.