Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask/ddl: refine manager error handling #48095

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Oct 30, 2023

What problem does this PR solve?

Issue Number: ref #46258, close #48064

Problem Summary:

What is changed and how it works?

  1. Check error retryable when init scheduler.
  2. Add ErrCreatePDClient for ha test met it.
  3. Check retryable error for dist task in ddl framework.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
@tiprow
Copy link

tiprow bot commented Oct 30, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #48095 (f69e4af) into master (173e485) will increase coverage by 1.7227%.
Report is 18 commits behind head on master.
The diff coverage is 58.3333%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48095        +/-   ##
================================================
+ Coverage   71.5914%   73.3142%   +1.7227%     
================================================
  Files          1401       1424        +23     
  Lines        405923     415783      +9860     
================================================
+ Hits         290606     304828     +14222     
+ Misses        95508      92125      -3383     
+ Partials      19809      18830       -979     
Flag Coverage Δ
integration 43.0013% <8.3333%> (?)
unit 72.1312% <58.3333%> (+0.5398%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0503% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7506% <ø> (-4.1526%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 10:01:25.844753741 +0000 UTC m=+2860883.431863872: ☑️ agreed by wjhuang2016.
  • 2023-10-30 10:11:10.460263884 +0000 UTC m=+2861468.047374014: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Oct 30, 2023
@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/retest

2 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 31, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 31, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 31, 2023

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 31, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 31, 2023

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot merged commit 2b18f64 into pingcap:master Oct 31, 2023
20 of 24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48138.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 1, 2023
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
6 participants