Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: handle region error for GetMvccByEncodedKey API(#47811) #47808

Merged
merged 6 commits into from
Oct 20, 2023
Merged

*: handle region error for GetMvccByEncodedKey API(#47811) #47808

merged 6 commits into from
Oct 20, 2023

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Oct 19, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #47807

Problem Summary: pick #47811

What is changed and how it works?

Before:

Related TIDB Log:

# rg "failed to get schema version"
tidb.log
9758:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
9760:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
9762:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
9764:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
10034:[2023/10/19 18:11:28.173 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]

img_v2_0f786210-a576-47d7-97e8-17d78c88324g

This PR:

# rg "failed to get schema version"
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
add backoff and region error check for GetMvccByEncodedKey API
b4a6acb 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2023
@tiprow
Copy link

tiprow bot commented Oct 19, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
add test
184412f 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
refine
310b493 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 changed the title *: add backoff and region error check for GetMvccByEncodedKey API *: handle region error for GetMvccByEncodedKey API Oct 19, 2023
@crazycs520 crazycs520 changed the title *: handle region error for GetMvccByEncodedKey API *: handle region error for GetMvccByEncodedKey API(#47811) Oct 19, 2023
zyguan
zyguan reviewed Oct 19, 2023
View reviewed changes
store/helper/helper.go Outdated
}
continue
}
return kvResp.Resp.(*kvrpcpb.MvccGetByKeyResponse), nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also translate resp.GetError() to the returned error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, addressed in #47811

store/helper/helper.go Outdated Show resolved Hide resolved
@crazycs520
refine test
9845018 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
update client-go
aa282ad 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 20, 2023
@crazycs520
make bazel_prepare
671e74e 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 03:08:13.918053724 +0000 UTC m=+1972091.505163862: ☑️ agreed by zyguan.
  • 2023-10-20 03:57:29.718556266 +0000 UTC m=+1975047.305666410: ☑️ agreed by cfzjywxk.

@cfzjywxk cfzjywxk merged commit d8fb9d4 into pingcap:tidb-6.5-with-kv-timeout-feature Oct 20, 2023
3 of 7 checks passed
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema
*: handle region error for GetMvccByEncodedKey API(pingcap#47811) (pi…
2a58cd8 
…ngcap#47808) (pingcap#12)

* add backoff and region error check for GetMvccByEncodedKey API

* update client-go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@zyguan zyguan zyguan approved these changes

@you06 you06 Awaiting requested review from you06

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@ekexium ekexium Awaiting requested review from ekexium

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazycs520 @cfzjywxk @zyguan